Closed
Conversation
Author
|
rerun failure checks |
3 similar comments
Author
|
rerun failure checks |
Author
|
rerun failure checks |
Author
|
rerun failure checks |
Author
|
@zymap Would you mind to help review it? |
hangc0276
requested review from
dlg99,
eolivelli,
hangc0276,
hezhangjian,
nicoloboschi and
zymap
Contributor
|
@wuzhanpeng Thanks for your contribution, would you please rebase the master? thanks. |
hangc0276
reviewed
Jul 26, 2022
| } | ||
| data.capacity(entrySize); | ||
| int rc = readFromLogChannel(entryLogId, bc, data, pos); | ||
| entryLogCounter.numOfScannedBytes.add(data.writableBytes()); |
Member
|
@wuzhanpeng Do you want to continue to work on this? If not, I will remove the release label |
Member
|
Move it to the next release since this PR is inactive. |
Member
|
fix old workflow,please see #3455 for detail |
Member
|
closed by inactive, feel free to reopen it if you still want to working on this :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
In our practice, when the throughput becomes larger, the trigger frequency of compaction will also increase, so that the scanning of entry log will also become frequent. It is well known that frequent read operations in HDD are a common cause of disk performance degradation, but we currently have no relevant monitoring information on this. Therefore, this pr provides a convenient way to provide additional monitoring of log scanning.
Changes
Add two counters for log scanning monitoring.